drop PDO for Teradata #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajca
requested review from
a team and
martinjunger
and removed request for
a team
|
👀 |
martinjunger
approved these changes
Apr 19, 2022
| @@ -12,6 +12,7 @@ | |||
| use Doctrine\DBAL\Driver\PDO\Exception; | |||
| use Doctrine\DBAL\Platforms\AbstractPlatform; | |||
| use Keboola\TableBackendUtils\Connection\ConnectionRetryWrapper; | |||
| use Keboola\TableBackendUtils\Connection\Snowflake\Exception\DriverException; | |||
There was a problem hiding this comment.
tohle neni hezky - je tam Snowflake namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDO doesn't work with Teradata ODBC driver, this is mostly copy paster from SNFLK to make it work, would be great to refactor this later, and make generic ODBC driver maybe.
There is also some small fixes:
kind of weird are CHARACTER SET value on columns, it was not part of HELP and than tests did fail as it was there. It's super confusing.