Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KBC-1886 Exasol: catch null constraint violation errors #81

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

zajca
Copy link
Member

@zajca zajca commented Oct 22, 2021

@zajca zajca requested review from a team and jirkasemmler and removed request for a team October 22, 2021 08:07
Copy link
Contributor

@jirkasemmler jirkasemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asi cajk, jen me napadla ta exception, ale pokud na to mas jiny nazor, tak to muzeme i nechat

$matches
);

return new Exception(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napada me, jestli nechceme tady radeji vyhazovat self:: . Se to pak da pripadne lepe odchytavat

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To není generická Exception, ale Keboola\Db\Import\Exception

@zajca zajca merged commit 54067c2 into master Oct 22, 2021
@zajca zajca deleted the zajca-kbc-1886 branch October 22, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants