feat: Add checks for invalid manifest jsonnet configuration #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First version of template returns errors as the len configurations == 0 Second version of template returns error as the configurations == 1 and the first configuration is `nil`. Third version of template returns bigquery writer templated side by side with snowflake writer. This test should be duplicated for `snowflake` backend and swapped checks within if statement.
Copy bigquery test case for snowflake initial state. First we check that configurations == 0 because of wrong if statement Secondly we check that configurations == 1 because of wrong if statement Thirdly the template is created appropriatelly for backend selected
…r when records are missing Used on empty manifest file which will be filled using `Save()` Method. Used on non empty manifest to store new records which will be filled using `Save()` Method.
Matovidlo
force-pushed
the
feat-add-checks-for-invalid-manifest-jsonnet-configuration
branch
from
96b9c5a to
49f8406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: PSGO-955
Changes: