Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add toxiproxy stream test #2175

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

Matovidlo
Copy link
Contributor

@Matovidlo Matovidlo commented Dec 9, 2024

Jira: PSGO-108

Changes:

  • Add toxiproxy dependency into container
  • Create new test with network failures
  • Adjust setup methods to work with new test.

We still receive error with no space left on device in tagged GH action workflows
Screenshot_20241209_130429


@Matovidlo Matovidlo force-pushed the feat-add-toxiproxy-stream-test branch 10 times, most recently from be1bb48 to 8ca2718 Compare December 12, 2024 11:01
@Matovidlo Matovidlo marked this pull request as ready for review December 12, 2024 11:43
@@ -151,6 +151,7 @@ func (c *ClientConnection) Close(ctx context.Context) error {

func (c *ClientConnection) dialLoop(ctx context.Context, initDone chan error) {
b := newClientConnBackoff()
b.InitialInterval = 100 * time.Millisecond
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to toxiproxy we have now higher latency and this often failed locally.

test/stream/bridge/keboola/keboola_test.go Outdated Show resolved Hide resolved

ts := setup(t)
client := toxiproxyClient.NewClient("localhost:8474")
proxy, err := client.CreateProxy("source1", ts.sourceURL1[7:len(ts.sourceURL1)-1], ts.sourceURL1[7:])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the source url is localhost:12345 i want to create new proxy on host:port localhost:1234.
It can be adjusted to randomized port

test/stream/bridge/keboola/keboola_test.go Outdated Show resolved Hide resolved
test/stream/bridge/keboola/keboola_test.go Outdated Show resolved Hide resolved
test/stream/bridge/keboola/keboola_test.go Outdated Show resolved Hide resolved
test/stream/bridge/keboola/keboola_test.go Outdated Show resolved Hide resolved
test/stream/bridge/keboola/keboola_test.go Outdated Show resolved Hide resolved
@Matovidlo Matovidlo force-pushed the feat-add-toxiproxy-stream-test branch from 8ca2718 to aad00b2 Compare December 13, 2024 12:25
@Matovidlo Matovidlo force-pushed the feat-add-toxiproxy-stream-test branch from aad00b2 to 86b6f90 Compare December 13, 2024 14:00
Copy link
Contributor

@hosekpeter hosekpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matovidlo Matovidlo merged commit 8d1500e into main Jan 6, 2025
12 checks passed
@Matovidlo Matovidlo deleted the feat-add-toxiproxy-stream-test branch January 6, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants