feat: Add option to download sliced file from staging storage without decompression #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hosekpeter
requested review from
jachym-tousek-keboola and
Matovidlo
as code owners
Matovidlo
reviewed
Nov 11, 2024
| StorageAPIToken configmap.Value[string] `configKey:"storage-api-token" configShorthand:"t" configUsage:"storage API token from your project"` | ||
| Output configmap.Value[string] `configKey:"output" configShorthand:"o" configUsage:"path to the destination file or directory"` | ||
| AllowSliced configmap.Value[bool] `configKey:"allow-sliced" configUsage:"output sliced files as a directory containing slices as individual files"` | ||
| WithOutDecompress configmap.Value[bool] `configKey:"without-decompress" configUsage:"treat the sliced files as individual files, without decompressing them."` |
There was a problem hiding this comment.
Suggested change
| WithOutDecompress configmap.Value[bool] `configKey:"without-decompress" configUsage:"treat the sliced files as individual files, without decompressing them."` | |
| WithoutDecompress configmap.Value[bool] `configKey:"without-decompress" configUsage:"do not decompress the downloaded files or sliced files."` |
test/cli/remote-file/download-file-disk-without-decompress/initial-state.json
Show resolved
Hide resolved
jachym-tousek-keboola
approved these changes
Nov 12, 2024
hosekpeter
requested review from
Matovidlo
and removed request for
Matovidlo
hosekpeter
force-pushed
the
petr-hosek-PSGO-859
branch
from
4e95e67 to
4f4f88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: PSGO-859
Changes: