Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dependabot branches not triggering CI #2121

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jachym-tousek-keboola
Copy link
Contributor

Okay one more thing. The dependabot PRs are not triggering workflows. I thought it was a temporary GitHub Actions issue at first but it's actually because the branches contain a / character.

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Copy link
Contributor

@Matovidlo Matovidlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We had discussion on that previously (with Michal) but we did not make this change that you suggest before. I think it is quite improvement for dependabot PRs :)

@jachym-tousek-keboola jachym-tousek-keboola merged commit b63dd04 into main Oct 23, 2024
12 checks passed
@jachym-tousek-keboola jachym-tousek-keboola deleted the fix-dependabot branch October 23, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants