Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add WithoutCancel context in task cleanup #2114

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Matovidlo
Copy link
Contributor

@Matovidlo Matovidlo commented Oct 22, 2024

Jira: PSGO-917

Changes:

  • The problem lays when we want to execute cleanup after context is done. Even though we create new context with timeout, the parent context is canceled, therefore we are not able to finish the cleanup.

The problem lays when we want to execute cleanup after context is done.
Even though we create new context with timeout, the parent context is
canceled, therefore we are not able to finish the cleanup.
@Matovidlo Matovidlo changed the title fix: Add withoutcancel context fix: Add Withoutcancel context in task cleanup Oct 22, 2024
@Matovidlo Matovidlo changed the title fix: Add Withoutcancel context in task cleanup fix: Add WithoutCancel context in task cleanup Oct 22, 2024
@Matovidlo Matovidlo marked this pull request as ready for review October 22, 2024 10:56
Copy link
Contributor

@hosekpeter hosekpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Matovidlo Matovidlo merged commit 1688b66 into main Oct 23, 2024
12 checks passed
@Matovidlo Matovidlo deleted the mv-PSGO-917-fix-test-cleanup-test branch October 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants