fix: Change configID uint64->string in preview mapper

keboola · Dec 18, 2024 · 8144504 · 8144504
1 parent 473080d
commit 8144504
Show file tree

Hide file tree

Showing 10 changed files with 16 additions and 23 deletions.
diff --git a/api/templates/design.go b/api/templates/design.go
@@ -1099,9 +1099,9 @@ var InstanceID = Type("InstanceId", String, func() {
 	Description("ID of the template instance.")
 })
 
-var ConfigID = Type("ConfigId", UInt64, func() {
-	Meta("struct:field:type", "= uint64")
-	Example(123456)
+var ConfigID = Type("ConfigId", String, func() {
+	Meta("struct:field:type", "= string")
+	Example("123456")
 	Description("Config ID of the configuration created by preview.")
 })
 

diff --git a/internal/pkg/service/templates/api/gen/http/templates/server/encode_decode.go b/internal/pkg/service/templates/api/gen/http/templates/server/encode_decode.go
diff --git a/internal/pkg/service/templates/api/gen/http/templates/server/types.go b/internal/pkg/service/templates/api/gen/http/templates/server/types.go
diff --git a/internal/pkg/service/templates/api/gen/templates/service.go b/internal/pkg/service/templates/api/gen/templates/service.go
diff --git a/internal/pkg/service/templates/api/openapi/openapi.json b/internal/pkg/service/templates/api/openapi/openapi.json
diff --git a/internal/pkg/service/templates/api/openapi/openapi.yaml b/internal/pkg/service/templates/api/openapi/openapi.yaml
@@ -2517,17 +2517,16 @@ definitions:
         type: object
         properties:
             configId:
-                type: integer
+                type: string
                 description: ID of the created/updated configuration. Typically used by preview endpoint
-                example: 1
-                format: int64
+                example: abc123
             instanceId:
                 type: string
                 description: ID of the created/updated template instance.
                 example: abc123
         description: Outputs generated by the task.
         example:
-            configId: 1
+            configId: abc123
             instanceId: abc123
     Template:
         title: Template

diff --git a/internal/pkg/service/templates/api/openapi/openapi3.json b/internal/pkg/service/templates/api/openapi/openapi3.json
diff --git a/internal/pkg/service/templates/api/openapi/openapi3.yaml b/internal/pkg/service/templates/api/openapi/openapi3.yaml
@@ -3780,17 +3780,16 @@ components:
             type: object
             properties:
                 configId:
-                    type: integer
+                    type: string
                     description: Config ID of the configuration created by preview.
-                    example: 123456
-                    format: int64
+                    example: "123456"
                 instanceId:
                     type: string
                     description: ID of the template instance.
                     example: V1StGXR8IZ5jdHi6BAmyT
             description: Outputs generated by the task.
             example:
-                configId: 123456
+                configId: "123456"
                 instanceId: V1StGXR8IZ5jdHi6BAmyT
         Template:
             type: object

diff --git a/internal/pkg/service/templates/api/service/mapper.go b/internal/pkg/service/templates/api/service/mapper.go
@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"slices"
 	"sort"
-	"strconv"
 	"time"
 
 	"github.com/spf13/cast"
@@ -87,12 +86,8 @@ func (m Mapper) TaskPayload(model task.Task) (r *Task, err error) {
 		}
 
 		if v, ok := model.Outputs["configId"].(string); ok {
-			configID, err := strconv.ParseUint(v, 10, 64)
-			if err != nil {
-				return nil, err
-			}
 			out.Outputs = &TaskOutputs{
-				ConfigID: &configID,
+				ConfigID: &v,
 			}
 		}
 	}

diff --git a/test/templates/api/repositories/template-preview/006-poll/expected-response.json b/test/templates/api/repositories/template-preview/006-poll/expected-response.json
@@ -9,6 +9,6 @@
   "duration": %d,
   "result": "template preview created",
   "outputs": {
-    "configId": %d
+    "configId": "%s"
   }
 }