Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7) Fix getTables request #75

Merged
merged 14 commits into from
Jan 4, 2019
Merged

7) Fix getTables request #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
140d988
refactor gettables
pivnicek Nov 8, 2018
f80baec
refactor where clause
pivnicek Nov 8, 2018
cb4ccbe
debug
pivnicek Nov 8, 2018
6b2e966
missing concatenation
pivnicek Nov 8, 2018
30f7288
remove debug
pivnicek Nov 8, 2018
8437b96
update to db-common 9.2.1
pivnicek Nov 9, 2018
7228dae
update to phpunit 7
pivnicek Nov 9, 2018
357b31d
remove phpunit syntax check
pivnicek Nov 9, 2018
b624fa3
fix expected output file
pivnicek Nov 9, 2018
1f30186
test for same table name in two different schemas
pivnicek Nov 29, 2018
867f157
refactor getTables query generation
pivnicek Dec 12, 2018
f5b90dd
OR, not AND :p
pivnicek Dec 12, 2018
d51763b
fix comment
pivnicek Jan 4, 2019
741419b
remove dropping of old table
pivnicek Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"keboola/php-csv-db-import": "~2.3.0"
},
"require-dev": {
"phpunit/phpunit": "4.6.*",
"phpunit/phpunit": "^7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the upgrade? And why not upgrade anything else (cs, phpstan)? I have to say I much prefer to create separate PR for any non-related changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must have been a reason, I think to match with the common-lib version, but you're right, should have been better done somewhere else. Shall I move it, or can we keep it just this once ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Keep it :)

"codeclimate/php-test-reporter": "^0.3",
"keboola/coding-standard": "^6.0",
"keboola/storage-api-client": "^4.14",
Expand Down
Loading