Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor reduction of confusion re Magisk v23/24 #235

Closed
wants to merge 1 commit into from

Conversation

TAbdiukov
Copy link

MagiskHide Props Config does not support Magisk v24, so it may be worthwhile mentioning to the newer users.

Related issue

@HuskyDG
Copy link

HuskyDG commented Dec 17, 2022

There is no need to use MagiskHide Props Config.
If you want to change fingerprint, why not just create a simple resetprop script or simple system.prop module 🤷

@kdrag0n kdrag0n closed this in 2fa8e34 Jan 6, 2023
@pndwal
Copy link

pndwal commented Jan 11, 2023

@kdrag0n

We generally won't need to set fingerprint any longer to pass CTS Profile match for either old S/N or new PI deviceIntegrity even in custom, China region, developer, beta uncertified ROMs etc w/ USNF 2.4.0 because we now have mismatched but passing fingerprint set for gms natively (to bypass hardware evaluation type enforcement in some devices for PI deviceIntegrity verdict) and working (passing) for all devices I'm aware of, so readme wording does need adjusting...

MagiskHide Props Config does not support Magisk v24, so it may be worthwhile mentioning to the newer users.

Related issue

This statement is false however; while @Didgeridoohan hasn't updated it lately (and is busy with life) MHPC certainly still works fine W/ Magisk 24+!!!... The linked issue is only asking for module update notification support (ie. an enhancement) since we got JSON based updates instead of notifications through old repo...

MHPC can still be used with no inherent problems w/ latest Magisk and may still be useful in some edge cases, I don't know, but the statement "MagiskHide Props Config is an easy way to do so on Magisk v23 and older" will only cause confusion.

Further, w/ native fingerprint spoofing the statement "You must already be able to pass basic CTS profile attestation" will no longer apply as even devices that couldn't pass with fallback and bypasses allowing Basic evaluation type use will generally pass with this addition...

@TAbdiukov
Copy link
Author

OP here. Thanks @pndwal ! I can confirm that I was unintentionally mistaken, and this PR is NOT to be merged. Thanks!

@TAbdiukov
Copy link
Author

Let's continue future discussion at #255

@pndwal
Copy link

pndwal commented Feb 26, 2023

OP here. Thanks @pndwal ! I can confirm that I was unintentionally mistaken, and this PR is NOT to be merged. Thanks!

👍 ... Well this was already merged on Jan 7... (See above; go to README.md line 7 re. Magisk 23 etc.)

Of course MHPC now serves no purpose with USNF, so this all needs rewording again anyway... 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants