adding timeout to allocate call and adding total timeout to allocate #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,6 +82,13 @@ const ( | |||
| batchWaitTime = 500 * time.Millisecond | |||
| ) | |||
|
|
|||
| const ( | |||
| // Timeout for an individual Allocate RPC call can take | |||
| remoteAllocateTimeout = 10 * time.Second | |||
There was a problem hiding this comment.
@kdima - is it worth making these CLI args of the allocator? In an ideal world, I think we'd want to set these to like 1s
There was a problem hiding this comment.
Yeah it's a bit weird. I could not find a good place to add them. Will ask the maintainers
added 27 commits
September 16, 2020 09:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: