Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nobara #156

Merged
merged 7 commits into from
Dec 24, 2024
Merged

Add Nobara #156

merged 7 commits into from
Dec 24, 2024

Conversation

PoorPocketsMcNewHold
Copy link
Contributor

@PoorPocketsMcNewHold PoorPocketsMcNewHold commented Dec 16, 2024

WARNING:root:Unknow Linux detected: {'id': 'nobara', 'version': '40', 'version_parts': {'major': '40', 'minor': '', 'build_number': ''}, 'like': 'rhel centos fedora', 'codename': ''}. You can report this warning to the extra-platforms project to improve detection heuristics.

https://nobaraproject.org

Tried to follow #94 to know what to modify and add.
There's mostly only two things of note.

  • Instead of using a loose Unicode icon for the Nobara OS, or just not adding any, I've used a NerdFont icon instead  (nf-linux-nobara/f380). So it will actually display correctly only when using a supported font. Otherwise, it will appear as an unknown or invisible character depending on the fonts.
  • I may have added the check, in all places. Making me think, the python script might try to check for Nobara multiple times (For example, It will check if it detect it is a UNIX like OS, and if it detects it is based on LINUX). Seems usual for the project, and doesn't seems to affect actual IRL performance.

Do note that I've used a NerdFont icon for it, which will only work for Nerdfont compatible fonts. Otherwise, I think it won't display anything of interest.
Once again, used the Nerdfont icon for it.
@kdeldycke
Copy link
Owner

Thanks @PoorPocketsMcNewHold for the contribution! And thanks for trying to add all the little details for a new distribution!

You opened the pandora box about the possibility for icons to be NerdFont-based. I'm ok with your proposal. We'll see if it make sense in the future to have a separate property to distinguish NerdFont icon from emoji icons. In the mean time, looks good to me!

Let's merge. And I'll fix some test failures before pushing a release.

@kdeldycke kdeldycke merged commit 4d10715 into kdeldycke:main Dec 24, 2024
23 of 65 checks passed
@kdeldycke kdeldycke added the ✨ enhancement Improvement or change to an existing feature label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Improvement or change to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants