Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inlayhint for config key type #1659

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 23, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

image

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added the lsp label Sep 23, 2024
@Peefy
Copy link
Contributor

Peefy commented Sep 23, 2024

I think the discussion is about an auto-completion feature rather than a type hint feature. 🤔

@coveralls
Copy link
Collaborator

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 10990778156

Details

  • 43 of 47 (91.49%) changed or added relevant lines in 2 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 70.591%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/ty/mod.rs 14 15 93.33%
kclvm/sema/src/advanced_resolver/node.rs 29 32 90.63%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/tests.rs 1 98.61%
kclvm/tools/src/LSP/src/state.rs 12 82.73%
Totals Coverage Status
Change from base Build 10917873891: -0.002%
Covered Lines: 51306
Relevant Lines: 72681

💛 - Coveralls

@He1pa He1pa merged commit 3f473fa into kcl-lang:main Sep 24, 2024
13 checks passed
He1pa added a commit to He1pa/KCLVM that referenced this pull request Oct 14, 2024
Peefy pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: he1pa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants