-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: literal str and join str inner completion #1092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
changed the title
feat: fix literal str and join str inner completion
fix: literal str and join str inner completion
Feb 27, 2024
Peefy
reviewed
Feb 27, 2024
Peefy
reviewed
Feb 27, 2024
Peefy
reviewed
Feb 27, 2024
kclvm/plugin/build/lib.macosx-11-arm64-cpython-39/kclvm_runtime.py
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 8077694267Details
💛 - Coveralls |
He1pa
force-pushed
the
fix_join_str_complete
branch
2 times, most recently
from
February 28, 2024 08:54
36a7afd
to
bc0a0ca
Compare
…on, and change the search for the nearest symbol during completion to the symbol one or two characters before the trigger. Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
He1pa
force-pushed
the
fix_join_str_complete
branch
from
February 28, 2024 08:55
bc0a0ca
to
68a8421
Compare
Peefy
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the special judgment for literal strings during completion, and change the search for the nearest symbol during completion to the symbol one or two characters before the trigger.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #1083
2. What is the scope of this PR (e.g. component or file name):
kclvm/tools/src/LSP/src/completion.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: