Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support flag when add oci ref #140

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Aug 28, 2024
@zong-zhe zong-zhe requested a review from Peefy August 28, 2024 08:17
@zong-zhe zong-zhe self-assigned this Aug 28, 2024
@coveralls
Copy link

coveralls commented Aug 28, 2024

Pull Request Test Coverage Report for Build 10594076010

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.355%

Totals Coverage Status
Change from base Build 10558688220: 0.0%
Covered Lines: 89
Relevant Lines: 620

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Aug 28, 2024

We add to support the following pattern for OCI source, the tag denotes the OCI source and version is the version defined in the kcl.mod file. Besides, the --oci flag can be omitted.

kcl mod add [<package>@version] --oci foo --tag bar

@zong-zhe zong-zhe changed the title feat: add a diagnostic for the invalid flag when add oci ref feat: support flag when add oci ref Aug 28, 2024
@Peefy Peefy merged commit fb9366b into kcl-lang:main Aug 28, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants