Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new column to viewer. #535

Closed
wants to merge 1 commit into from
Closed

Add new column to viewer. #535

wants to merge 1 commit into from

Conversation

DanMiel
Copy link
Contributor

@DanMiel DanMiel commented Oct 31, 2022

Better error descriptions for the CD files.

Better error descriptions.
@luzpaz
Copy link
Contributor

luzpaz commented Nov 1, 2022

Link to #505

@luzpaz
Copy link
Contributor

luzpaz commented Nov 1, 2022

@DanMiel looks like this branch is conflicting, can you rebase and fix the issues?

@DanMiel
Copy link
Contributor Author

DanMiel commented Nov 1, 2022

luzpaz: kbwbe added some translating functions in the code. I'll need to cancel the PR and go through the changed files line by line.
Is the best way to close the PR just to hit "Close"?
Perhaps it would be better to take my additions out of kbwle's files and I can make a separate add-on with them. His programing is over my head.
Dan

@DanMiel DanMiel closed this Nov 2, 2022
@luzpaz
Copy link
Contributor

luzpaz commented Nov 2, 2022

I guess you can make an addon on an addon. But translations are a beast by themselves. It's not super complicated once you understand https://wiki.freecadweb.org/Translating_an_external_workbench

@DanMiel
Copy link
Contributor Author

DanMiel commented Nov 2, 2022

It doesn't look like the translations are bad (thanks for the link). My tremors have gotten worse, and it takes me a while me a long time to select things on the computer and type. The changes I did on the files were fairly major so it will take me a while to add them to kbwbe's files. Please be patient.

@DanMiel
Copy link
Contributor Author

DanMiel commented Nov 4, 2022

luzpaz: I fixed the files and instead of reopening this PR I opened PR536 to update my CD (Constraint Diagnostic) files. These files do not affect PR 505 which are kbwbe's files.
Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants