Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api_versions and kube_version to helm_charts block #253

Merged
merged 1 commit into from
May 11, 2024

Conversation

FlxPeters
Copy link

@FlxPeters FlxPeters commented Apr 11, 2024

There are some field mappings missing the helm_charts block.
This MR adds the api_versions list and the kube_version field in order to provide this fields to an Helm chart using the $.Capabilities.APIVersions.Has checks.

Refference:

Copy link
Member

@pst pst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I take more helm stuff that I don't use and don't understand into the code base, I must require it to include tests. Otherwise, I can't know if any future work I do breaks it or not. I'm sure you will understand.

docs/data-sources/overlay.md Outdated Show resolved Hide resolved
@FlxPeters FlxPeters requested a review from pst May 5, 2024 19:11
Copy link
Member

@pst pst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests I asked for. I'll work on cutting a release this weekend so you can use your contribution more easily.

@pst pst merged commit 2333640 into kbst:master May 11, 2024
lambchop4prez referenced this pull request in lambchop4prez/network May 26, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[kustomization](https://registry.terraform.io/providers/kbst/kustomization)
([source](https://togithub.com/kbst/terraform-provider-kustomization)) |
required_provider | patch | `0.9.5` -> `0.9.6` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>kbst/terraform-provider-kustomization (kustomization)</summary>

###
[`v0.9.6`](https://togithub.com/kbst/terraform-provider-kustomization/releases/tag/v0.9.6)

[Compare
Source](https://togithub.com/kbst/terraform-provider-kustomization/compare/v0.9.5...v0.9.6)

#### What's Changed

- Use kustomize_options as block in example by
[@&#8203;torvitas](https://togithub.com/torvitas) in
[https://github.com/kbst/terraform-provider-kustomization/pull/247](https://togithub.com/kbst/terraform-provider-kustomization/pull/247)
- updating Go and deps to fix CVEs by
[@&#8203;valeriodelsarto](https://togithub.com/valeriodelsarto) in
[https://github.com/kbst/terraform-provider-kustomization/pull/249](https://togithub.com/kbst/terraform-provider-kustomization/pull/249)
- Add api_versions and kube_version to helm_charts block by
[@&#8203;FlxPeters](https://togithub.com/FlxPeters) in
[https://github.com/kbst/terraform-provider-kustomization/pull/253](https://togithub.com/kbst/terraform-provider-kustomization/pull/253)

#### New Contributors

- [@&#8203;torvitas](https://togithub.com/torvitas) made their first
contribution in
[https://github.com/kbst/terraform-provider-kustomization/pull/247](https://togithub.com/kbst/terraform-provider-kustomization/pull/247)
- [@&#8203;valeriodelsarto](https://togithub.com/valeriodelsarto) made
their first contribution in
[https://github.com/kbst/terraform-provider-kustomization/pull/249](https://togithub.com/kbst/terraform-provider-kustomization/pull/249)
- [@&#8203;FlxPeters](https://togithub.com/FlxPeters) made their first
contribution in
[https://github.com/kbst/terraform-provider-kustomization/pull/253](https://togithub.com/kbst/terraform-provider-kustomization/pull/253)

**Full Changelog**:
kbst/terraform-provider-kustomization@v0.9.5...v0.9.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/lambchop4prez/network).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants