-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbss-cvut/record-manager-ui#71] Reduce the size of PatientRecordDto data #45
Conversation
…data. Also update code to the new OWL2Java constant naming strategy.
… build. Required updated jopa-spring-transaction.
…ing in PatientRecordDao.
…se generic record filtering to get records from institution.
…o record REST API.
…ng-sorting Record manager UI#71 filtering paging sorting
Note that the changes regarding kbss-cvut/record-manager-ui#71 are backwards compatible with the frontend, so the PR can be merged without waiting for frontend implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just have a look at my comment.
@OWLObjectProperty(iri = Vocabulary.s_p_has_author, fetch = FetchType.EAGER) | ||
private User author; | ||
@OWLObjectProperty(iri = Vocabulary.s_p_has_author) | ||
private URI author; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that we won't be using it to show provenance information before the record is fully loaded:
I guess we do not need to optimize PatientRecordDto too much anymore since implementing on the backend, so I was wondering if it is not useful to leave there User author
instead (at least developer friendly:). I guess the most important argument to consider is that we do it somehow consistently across the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and the current frontend works well with this backend, so picture above is not the issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OWLObjectProperty(iri = Vocabulary.s_p_has_last_editor, fetch = FetchType.EAGER) | ||
private User lastModifiedBy; | ||
@OWLObjectProperty(iri = Vocabulary.s_p_has_last_editor) | ||
private URI lastModifiedBy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
kbss-cvut/record-manager-ui#71.