Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to Spring Boot #2

Merged
merged 13 commits into from
Oct 18, 2023
Merged

Migration to Spring Boot #2

merged 13 commits into from
Oct 18, 2023

Conversation

ledsoft
Copy link

@ledsoft ledsoft commented Oct 13, 2023

  • Migrated to Spring Boot 3
  • Rewrite transaction management to declarative (using @Transactional)
  • Migrated tests to JUnit 5

Implements #1.

ledsoft added 11 commits October 12, 2023 09:49
@ledsoft
[Upd] Migrate to Spring Boot 3.
55f584d 
Modify dependencies, refactor configuration.
@ledsoft
[Upd] Migrate tests to JUnit 5, fix test issues.
b063a03
@ledsoft
[Ref] Modify login processing URL to match the old configuration.
74edd2c
@ledsoft
[Upd] Update Dockerfile to work with the new application.
89efce0 
Build the application as part of image build.
@ledsoft
[Upd] Update GitHub actions, make them specific for this repository.
f80fd71
@ledsoft
[Doc] Update documentation and readme.
032d1b0
@ledsoft
[Doc] Remove Apache Tomcat from requirements.
c3e3d38
@ledsoft
[Ref] Introduce annotation-based transactional processing.
5f2f94a 
Refactor DAO tests to use this transactional processing.
@ledsoft
[Ref] Refactor tests to use the declarative transactions.
ad8f1d2
@ledsoft
[Fix] Fix OFN link in readme.
0f4384c
@ledsoft
[Ref] Code cleanup, add some explanatory comments.
c30e609
@ledsoft ledsoft requested a review from blcham October 13, 2023 06:13
@ledsoft ledsoft marked this pull request as draft October 13, 2023 10:42
@ledsoft ledsoft marked this pull request as ready for review October 13, 2023 11:38
blcham
blcham requested changes Oct 18, 2023
View reviewed changes
Copy link

@blcham blcham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 2 micro changes, can be merged afterwards.

docker-compose.yml Outdated Show resolved Hide resolved
src/main/java/cz/cvut/kbss/study/persistence/dao/BaseDao.java Show resolved Hide resolved
@blcham blcham merged commit 86d8e2d into kbss-cvut:main Oct 18, 2023
This was referenced Oct 18, 2023
Closed
Closed
blcham pushed a commit that referenced this pull request Feb 1, 2024
@ledsoft
Merge pull request #2 from akaene/record-manager-ui#71-filtering-pagi…
db451c8 
…ng-sorting

Record manager UI#71 filtering paging sorting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blcham blcham blcham requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ledsoft @blcham