Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate getLastResponse...() and request...() in Clients #426

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

Art4
Copy link
Collaborator

@Art4 Art4 commented Oct 8, 2024

Closes #391.

@Art4 Art4 added this to the v2.8.0 milestone Oct 8, 2024
@Art4 Art4 self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (599f589) to head (cf370a2).
Report is 7 commits behind head on v2.x.

Additional details and impacted files
@@            Coverage Diff            @@
##               v2.x     #426   +/-   ##
=========================================
  Coverage     98.60%   98.61%           
  Complexity      657      657           
=========================================
  Files            29       29           
  Lines          2001     2015   +14     
=========================================
+ Hits           1973     1987   +14     
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Art4 Art4 marked this pull request as draft October 10, 2024 11:21
@Art4 Art4 mentioned this pull request Oct 10, 2024
@Art4 Art4 changed the title Deprecate getLastResponseStatusCode, getLastResponseContentType and getLastResponseBody in Clients Deprecate getLastResponse...() and request...() in Clients Oct 10, 2024
@Art4 Art4 marked this pull request as ready for review October 10, 2024 15:02
@Art4 Art4 requested a review from kbsali October 11, 2024 09:30
@Art4 Art4 merged commit 5e0f1cb into kbsali:v2.x Oct 14, 2024
12 checks passed
@Art4 Art4 deleted the 391-deprecate-last-response-methods-in-clients branch October 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate getLastResponse...() and request...() in Clients
2 participants