Fix Blobstore failure response #101
Conversation
Fixed a bug where if the Blobstore returned an non-json response, logging the response would fail due to attempting to concatenate string and binary types. This would shadow the real error returned from the Blobstore. Also changed a few Shock references to Blobstore. Baby steps.
MrCreosote
requested review from
jsfillman,
qzzhang and
Tianhao-Gu
as code owners
| # this means shock is down or not responding. | ||
| log("Couldn't parse response error content from Shock: " + | ||
| response.content) | ||
| # this means the Blobstore is down or not responding. | ||
| log("Couldn't parse response error content from the Blobstore: " + response.text) |
Standard SDK docker image too old issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 71.53% 71.53%
=======================================
Files 5 5
Lines 1212 1212
=======================================
Hits 867 867
Misses 345 345 ☔ View full report in Codecov by Sentry. |
|
|
||
| jobs: | ||
|
|
||
| sdk_tests: | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
I know that GitHub Actions is transitioning ubuntu-latest from 22.04 to 24.04. However, to me the current ubuntu-latest is 24.04, does it make sense to continue using ubuntu-latest, or could there be potential issues to consider?
There was a problem hiding this comment.
I just copied the test.yml file from another sdk repo that was already updated. I don't have strong feelings about using 22 or 24, but I do think we should pin the version. That being said, I really doubt that pinning 22 vs 24 will make a difference.
If you want to use 22 I'm fine with that, or we can keep it as is.
There was a problem hiding this comment.
Oh, you already approved. Ok, I'll merge and I can change it to 22 if you think that's important
Fixed a bug where if the Blobstore returned an non-json response, logging the response would fail due to attempting to concatenate string and binary types. This would shadow the real error returned from the Blobstore.
Also changed a few Shock references to Blobstore. Baby steps.