Fix WebdriverIO configs #3663
Fix WebdriverIO configs #3663
Conversation
|
| @@ -16,7 +16,7 @@ describe('Narrative tree page with login', () => { | |||
| }); | |||
|
|
|||
| it('opens a narrative', async () => { | |||
| await browser.url(makeURL(`narrative/${testCases.CASE_1.narrativeId}`)); | |||
There was a problem hiding this comment.
makeURL (which just prepends the BASE_URL) isn't necessary. wdio does that for us. Was fiddling around here when I found that - will update other specs in a later PR.
| const env = process.env.ENV || 'ci'; | ||
| const testData = require('./narrative_basic_data.json'); | ||
| const testCases = testData.envs[env]; | ||
|
|
||
| describe('Narrative tree page with login', () => { | ||
| beforeEach(async () => { | ||
| await browser.setTimeout({ implicit: 30000 }); |
There was a problem hiding this comment.
implicit timeouts shouldn't be used, according to docs.
| @@ -4,8 +4,6 @@ | |||
| const testConfig = require('../testConfig'); | |||
| const fs = require('fs'); | |||
|
|
|||
| const CHROME_BINARY = require('puppeteer').executablePath(); | |||
There was a problem hiding this comment.
wdio fetches whatever version you tell it to, now, and does the pathing itself.
This might also make the puppeteer dependency obsolete, will check in a later PR.
| 'headless', | ||
| 'disable-gpu', |
There was a problem hiding this comment.
Updating args according to docs.
| return { | ||
| browserName: 'chrome', | ||
| browserVersion: '128', |
There was a problem hiding this comment.
latest version of Chrome. Not sure yet if we can add a spread of these (or if we need to, I think our policy is to stick to the latest).
That should probably get configured elsewhere rather than as a magic number here, but... later.
| }, | ||
| 'wdio:enforceWebDriverClassic': true |
There was a problem hiding this comment.
The latest wdio uses the w3-specced webdriver BiDi protocol. There's something strange with either our configuration, or the mash of versions of things, that prevents that protocol from loading pages from our app. So forcing it back to webDriverClassic fixes that (at least, until they ditch that all together).
| @@ -322,7 +317,7 @@ const wdioConfig = { | |||
| // and 30 processes will get spawned. The property handles how many capabilities | |||
| // from the same test should run tests. | |||
| // | |||
| maxInstances: 10, | |||
| maxInstances: 1, | |||
There was a problem hiding this comment.
It'd be really nice to have this run parallel, but those runs seem to clobber each other. I suspect shenanigans with cookies getting globally added and removed, and communication with the single narrative application we have running. I think it's worth trying to fix that by ensuring that each test spec only uses a single narrative, but this PR's just about returning to status quo.
| @@ -392,7 +387,6 @@ const wdioConfig = { | |||
| // Services take over a specific job you don't want to take care of. They enhance | |||
| // your test setup with almost no effort. Unlike plugins, they don't add new | |||
| // commands. Instead, they hook themselves up into the test process. | |||
| services: [[testParams.SERVICE, serviceConfigs[testParams.SERVICE]]], | |||
There was a problem hiding this comment.
These told wdio to use the chromedriver service, which doesn't exist anymore, and was crashing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3663 +/- ##
===========================================
- Coverage 25.93% 25.89% -0.05%
===========================================
Files 461 461
Lines 46652 46652
===========================================
- Hits 12099 12079 -20
- Misses 34553 34573 +20 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description of PR purpose/changes
The last batch of JS updates played some havoc with the webdriverio configs.
Mainly, in a previous major version of wdio, they started wrapping the most popular browser drivers into wdio itself, which made the
wdio-chromedriver-serviceobsolete. Which, it hasn't been updated in 2 years and has been marked obsolete on Github, so that's a good thing anyway.But the configs needed a little patching and updating to tell wdio we're not using that service anymore.
Eventually, we'll need to do the same for the standalone-selenium-service (which was put in to talk to firefox), and do some fiddling with browserstack (which I don't think we're actually using).
Chrome alone gets used in GHA, so that gets priority here.
There's a bunch of other little bits of polish to add to the config situation, too, but that's a later project. This does need to fixed, though to get integration tests passing again, and so I can put in more to handle this auth business.