Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE2022-145: retrieve tool reference from yaml file #510

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Conversation

Tianhao-Gu
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (9c2eb4e) 45.96% compared to head (7fbd7d5) 45.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
- Coverage   45.96%   45.85%   -0.11%     
==========================================
  Files          73       73              
  Lines        6177     6194      +17     
==========================================
+ Hits         2839     2840       +1     
- Misses       3338     3354      +16     
Files Coverage Δ
src/loaders/compute_tools/tool_version.py 23.07% <11.11%> (-6.34%) ⬇️
src/loaders/jobs/taskfarmer/task_generator.py 21.62% <30.76%> (-1.24%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/loaders/compute_tools/checkm2/versions.yaml Outdated Show resolved Hide resolved
src/loaders/jobs/taskfarmer/task_generator.py Outdated Show resolved Hide resolved
src/loaders/jobs/taskfarmer/task_generator.py Outdated Show resolved Hide resolved
docs/generate_genome_data.md Outdated Show resolved Hide resolved
docs/generate_genome_data.md Show resolved Hide resolved
docs/generate_genome_data.md Outdated Show resolved Hide resolved
docs/generate_genome_data.md Outdated Show resolved Hide resolved
src/loaders/compute_tools/tool_version.py Outdated Show resolved Hide resolved
src/loaders/jobs/taskfarmer/task_generator.py Outdated Show resolved Hide resolved
src/loaders/jobs/taskfarmer/task_generator.py Outdated Show resolved Hide resolved
MrCreosote
MrCreosote previously approved these changes Oct 26, 2023
Copy link
Member

@MrCreosote MrCreosote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/generate_genome_data.md Outdated Show resolved Hide resolved
@Tianhao-Gu Tianhao-Gu merged commit d4e194c into main Oct 26, 2023
11 of 13 checks passed
@Tianhao-Gu Tianhao-Gu deleted the tool_ref_data branch October 26, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants