Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep option to FE entrypoint #9

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Add sleep option to FE entrypoint #9

merged 2 commits into from
Jun 17, 2024

Conversation

MrCreosote
Copy link
Member

Useful for debugging configs in Rancher if the service doesn't start

Useful for debugging configs in Rancher if the service doesn't start
@MrCreosote MrCreosote requested a review from Tianhao-Gu June 16, 2024 17:54
Starrocks docs don't make this as clear as it could be
Copy link

@Tianhao-Gu Tianhao-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrCreosote MrCreosote merged commit 1857841 into main Jun 17, 2024
2 checks passed
@bio-boris
Copy link

The trick is to set the entrypoint to /bin/sleep and the cmd to infinity so you can put any container to sleep without needing to modify anything. Most containers have /bin/sleep built in

@bio-boris
Copy link

Then you can call your old entrypoint as usual, since its a bash script, and you can figure out exactly where it crashes and such.

@MrCreosote
Copy link
Member Author

The docker compose set up from starrocks had a sleep in the (long) command, so when I converted the image to use envvars I put the sleep in the entry point so it behaved the same way. I just copied the same thing to the fe here.

Plus it lets you just set an envvar instead of changing the entrypoint and command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants