Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise fallback.md #791

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Revise fallback.md #791

merged 2 commits into from
Mar 6, 2020

Conversation

jlebar
Copy link
Contributor

@jlebar jlebar commented Mar 3, 2020

I was finding the contents of fallback.md hard to understand. I've made an attempt to revise it.

  • Change translation key from message to hello because messages is a special keyword in vue-i18n, and then it looks like message might also be special.
  • Add summaries atop each section so it's clear what config feature we're discussing.
  • Change translation key to Hello, world! to make it clear that you can include special characters in the key -- that's sort of the whole point of this section.
  • Revise for English idiom (e.g. "enrich this feature" is not idiomatic).

I was finding the contents of fallback.md hard to understand.  I've made an attempt to revise it.
@kazupon kazupon changed the base branch from master to v8.x March 6, 2020 07:55
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants