Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ improvement(warnings): make warning messages clearer #396

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

kimuraz
Copy link
Contributor

@kimuraz kimuraz commented Jul 23, 2018

Closes #393

@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #396 into dev will not change coverage.
The diff coverage is 60%.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev    #396   +/-   ##
=====================================
  Coverage   95.9%   95.9%           
=====================================
  Files          9       9           
  Lines        635     635           
=====================================
  Hits         609     609           
  Misses        26      26
Impacted Files Coverage Δ
src/directive.js 92% <60%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4d961...f25695e. Read the comment docs.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😭

@kazupon kazupon merged commit 79eee1b into kazupon:dev Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants