Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add locale arg type i18n.n method type signature #1194

Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix: add locale arg type i18n.n method type signature #1194

merged 1 commit into from
Apr 29, 2021

Conversation

faraz5040
Copy link
Contributor

@faraz5040 faraz5040 commented Apr 29, 2021 •
edited
Loading

Add type for using $n method with three args of number, NumberFormatOptions, locale.
Closes #1178

kazupon
kazupon approved these changes Apr 29, 2021
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Apr 29, 2021
@kazupon kazupon merged commit 1595188 into kazupon:v8.x Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
PR: merged Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$n method type
2 participants
@faraz5040 @kazupon