[perf] Use Set so lookup of _dataListeners can be O(1) #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
approved these changes
Apr 9, 2021
kazupon
added
PR: unreviewed
Type: Bug
|
@exoego nice pr! @exoego @kazupon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially adresses #926
This PR changes the internal
_dataListenersfromArraytoSet, so lookup can be O(1) instead of O(n)Original idea is proposed by @emarbo in #926 (comment)
Theoretically
Setrequires more memory than simpleArray, but I think it can be negligible: the number of elements may be from dozens to hundreds for most cases.Sacrificing some memory is rational improving time of destroying.
IIUC,
Setis in all browsers supported by Vue 2.x: https://caniuse.com/?search=javascript%20set