Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escapeParameterHtml parameter. #1002 #1009

Conversation

gardarh
Copy link
Contributor

@gardarh gardarh commented Oct 6, 2020

Adds the escapeParameterHtml flag which protects agains XSS vulnerabilities when output from $t() is passed in as v-html. In most situations setting this flag as true should not negatively impact existing code.

Please see issue #1002 for details.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #1009 into v8.x will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v8.x    #1009      +/-   ##
==========================================
+ Coverage   96.46%   96.49%   +0.03%     
==========================================
  Files          10       10              
  Lines         904      913       +9     
==========================================
+ Hits          872      881       +9     
  Misses         32       32              
Impacted Files Coverage Δ
src/index.js 97.83% <100.00%> (+0.01%) ⬆️
src/util.js 98.57% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba214d...b584bf2. Read the comment docs.

@gardarh gardarh force-pushed the 1002-add-flag-to-automatically-escape-html-in-parameters branch from 1bdab54 to b584bf2 Compare October 6, 2020 12:49
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works!
Thanks!
LGTM! 👍

@kazupon kazupon added the Type: Feature Includes new features label Oct 6, 2020
@kazupon kazupon merged commit db6edc3 into kazupon:v8.x Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged Type: Feature Includes new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants