Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues with big i18n files #165

Closed
razyon opened this issue May 24, 2017 · 2 comments
Closed

Performance issues with big i18n files #165

razyon opened this issue May 24, 2017 · 2 comments

Comments

@razyon
Copy link

razyon commented May 24, 2017

Hi,

In my project we have a huge i18n file (~2000 lines) for all the application and we came across big performance loss specially on mobile devices and Internet Explorer.

After some profiling of our app with the chome dev tools we found that the most consuming function of all our project is the looseClone function in your library.

I think maybe cloning the entire message list every time a translation is done is not the right thing to do as VueJS will refresh the translation every time the scope of the component has changed (If you type into an input, all the translations of the component linked to that input will be re-translated again).

For all I see, this looseClone is just a security that ensures that the users of the library will not break it by changing the messages on the fly. Couldn't it be enough to call looseClone in the setter of "prototypeAccessors.locale" ?

Regards,
David

@ahoo
Copy link

ahoo commented Oct 24, 2019

this issue still exists?

@razyon
Copy link
Author

razyon commented Oct 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants