💥 breaking: change fallbackRoot and sync option default true value

kazupon · Mar 18, 2017 · 0890b44 · 0890b44
1 parent a6b7e37
commit 0890b44
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/index.js b/src/index.js
@@ -14,7 +14,7 @@ export default class VueI18n {
   _vm: any
   _formatter: Formatter
   _root: ?I18n
-  _sync: ?boolean
+  _sync: boolean
   _fallbackRoot: boolean
   _fallbackLocale: Locale
   _missing: ?MissingHandler
@@ -29,8 +29,8 @@ export default class VueI18n {
     this._formatter = options.formatter || new BaseFormatter()
     this._missing = options.missing
     this._root = options.root || null
-    this._sync = options.sync || false
-    this._fallbackRoot = options.fallbackRoot || false
+    this._sync = options.sync === undefined ? true : !!options.sync
+    this._fallbackRoot = options.fallbackRoot === undefined ? true : !!options.fallbackRoot
 
     this._exist = (message: Object, key: Path): boolean => {
       if (!message || !key) { return false }

diff --git a/src/mixin.js b/src/mixin.js
@@ -49,7 +49,7 @@ export default {
         }
         this.$i18n = new VueI18n(options.i18n)
         defineComputed(this, options)
-        if (options.i18n.sync) {
+        if (options.i18n.sync === undefined || !!options.i18n.sync) {
           this._localeWatcher = this.$i18n.watchLocale()
         }
       } else {

diff --git a/test/unit/component.test.js b/test/unit/component.test.js
@@ -22,7 +22,7 @@ describe('component translation', () => {
         child1: { // translation with component
           i18n: {
             locale: 'en',
-            fallbackRoot: true,
+            sync: false,
             messages: {
               en: { who: 'child1' },
               ja: { who: '子1' }
@@ -49,7 +49,6 @@ describe('component translation', () => {
           components: {
             'sub-child2': {
               i18n: {
-                sync: true,
                 messages: {
                   en: { who: 'sub-child2' },
                   ja: { who: 'サブの子2' }