Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nfs node pvc backend #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mvalsecc
Copy link
Contributor

@mvalsecc mvalsecc commented Mar 31, 2024

  • The NFS VM provision bits are done
  • nfs-subdir-external-provisioner provisioning logic is done

@mvalsecc
Copy link
Contributor Author

mvalsecc commented Apr 2, 2024

Tasks left @mvalsecc

  • The playbook in this PR works out of the box with Fedora32 and Rocky Linux 8.9, but it seems not to work with Fedora Server 39. I fiddled with it for a while, then I just settled on using Rocky Linux instead as per we spoke offline.
  • Add the NFS server install and export setup tasks
  • Remove unneeded comments
  • Move most set_facts tasks to be parameters inside vars
  • Include setup-openshift-install-nfs-subdir-external-provisioner.yaml after the cluster has been up and running
  • confirm 03_cleanup.yaml removes all the storage VM related files
  • confirm RockyOS download qcow2 file is downloaded only if ff_provision_storage is true
  • Test with OKD as well

Things to double check @kazuhisya

  • Choose the OS to use for the NFS server: Rocky Linux 8.9
  • Decide how many GB do we want the NFS export to be (by default): 50
  • Decide whether to use username/pwd or ssh-key access to the NFS node: both (root pwd hardcoded to root for cloud and root users)
  • ff_provision_storage decides whether to deploy the NFS VM, and create the storageclass or not

Memo: Clean up tasks (to be implemented in another PR)

  • Should I Update the image in the README.md to show the storage node as well?
  • After this PR is merged, we do download quite a lot files on the first execution (as the NFS server needs another OS). I thought it might be a good idea to start tweaking the file download tasks (i.e. get_materials.yml to be async async. Let me know if I should do into this PR, on what!
  • BONUS POINT: If we want to add some test code (as in an external "test-pvc.yaml", we can add a minimal app using a test claim, see if it spins up, and then delete it.): DONE (see tests folder)
    echo "Creating demo deployment in demo namespace..."
    kubectl create namespace demo 2>/dev/null
    kubectl apply -f ../resources/app/app_with_pvc_using_external_provisioner_storage_class.yaml -n demo
    

Add storage node(s) VM creation logic.
Add helm binary, and Rocky Linux qcow2 image download tasks.
Add nfs-subdir-external-provisioner.
@mvalsecc mvalsecc force-pushed the feature/nfs-node-pvc-backend branch 2 times, most recently from 195f4ce to 2a51541 Compare April 16, 2024 07:03
@mvalsecc mvalsecc force-pushed the feature/nfs-node-pvc-backend branch from 2a51541 to b66ce1e Compare April 16, 2024 12:07
@mvalsecc mvalsecc marked this pull request as ready for review April 16, 2024 13:59
@@ -111,6 +113,12 @@ url:
{%- endif -%}
sha256_client_url: "{{ static.clients_base_url }}/sha256sum.txt"

# Hardcoded for now
helm_client: "https://get.helm.sh/helm-v3.14.3-linux-amd64.tar.gz" # TODO: figure out how to get the correct arch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One option would be to use this script to get the correct architecture helm binary. Up to you! @kazuhisya

$ curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
$ chmod 700 get_helm.sh
$ ./get_helm.sh

@mvalsecc mvalsecc changed the title WIP Feature/nfs node pvc backend Feature/nfs node pvc backend Apr 25, 2024
@mvalsecc mvalsecc force-pushed the feature/nfs-node-pvc-backend branch 2 times, most recently from edf0358 to 92c3cb2 Compare May 2, 2024 08:24
@mvalsecc mvalsecc force-pushed the feature/nfs-node-pvc-backend branch from 92c3cb2 to d9ca3a3 Compare May 2, 2024 08:30
@kazuhisya
Copy link
Owner

wip at 4ac5068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants