-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nfs node pvc backend #51
Open
mvalsecc
wants to merge
4
commits into
kazuhisya:master
Choose a base branch
from
mvalsecc:feature/nfs-node-pvc-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvalsecc
commented
Apr 1, 2024
Tasks left @mvalsecc
Things to double check @kazuhisya
Memo: Clean up tasks (to be implemented in another PR)
|
Add storage node(s) VM creation logic. Add helm binary, and Rocky Linux qcow2 image download tasks. Add nfs-subdir-external-provisioner.
mvalsecc
force-pushed
the
feature/nfs-node-pvc-backend
branch
2 times, most recently
from
April 16, 2024 07:03
195f4ce
to
2a51541
Compare
mvalsecc
force-pushed
the
feature/nfs-node-pvc-backend
branch
from
April 16, 2024 12:07
2a51541
to
b66ce1e
Compare
mvalsecc
commented
Apr 17, 2024
@@ -111,6 +113,12 @@ url: | |||
{%- endif -%} | |||
sha256_client_url: "{{ static.clients_base_url }}/sha256sum.txt" | |||
|
|||
# Hardcoded for now | |||
helm_client: "https://get.helm.sh/helm-v3.14.3-linux-amd64.tar.gz" # TODO: figure out how to get the correct arch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One option would be to use this script to get the correct architecture helm binary. Up to you! @kazuhisya
$ curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3
$ chmod 700 get_helm.sh
$ ./get_helm.sh
mvalsecc
changed the title
WIP Feature/nfs node pvc backend
Feature/nfs node pvc backend
Apr 25, 2024
mvalsecc
force-pushed
the
feature/nfs-node-pvc-backend
branch
2 times, most recently
from
May 2, 2024 08:24
edf0358
to
92c3cb2
Compare
mvalsecc
force-pushed
the
feature/nfs-node-pvc-backend
branch
from
May 2, 2024 08:30
92c3cb2
to
d9ca3a3
Compare
wip at 4ac5068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nfs-subdir-external-provisioner
provisioning logic is done