Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decaf library #38

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Update decaf library #38

merged 3 commits into from
Oct 17, 2024

Conversation

hololeap
Copy link

Fix for #37

8be9856 is reverted and the decaf library is updated using cede6185df1dad9d6e465dddc7f02698d8553726 from https://git.code.sf.net/p/ed448goldilocks/code

This seems to be working on my end (compiles successfully and tests pass even with --ghc-option=-optc-march=znver2).

Restore the old stack alignment in order to provide AVX2
compatibility.

This reverts commit 8be9856.

Signed-off-by: hololeap <[email protected]>
Update upstream commit and path for decaf_tables.c

Signed-off-by: hololeap <[email protected]>
Generate C code from upstream commit
cede6185df1dad9d6e465dddc7f02698d8553726

The following code in the upstream repo was run:
    cmake .
    make decaf_tables decaf-static all

Signed-off-by: hololeap <[email protected]>
Copy link
Owner

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazu-yamamoto kazu-yamamoto merged commit 593395e into kazu-yamamoto:main Oct 17, 2024
@kazu-yamamoto
Copy link
Owner

A new version has been released.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants