-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CloudFront Standard Log Parser #4
Merged
Merged
+478
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiwara
reviewed
Mar 29, 2021
README.md
Outdated
@@ -38,6 +38,8 @@ $ s3-object-router \ | |||
Usage of s3-object-router: | |||
-bucket string | |||
destination S3 bucket name | |||
-convert-json-record | |||
convert the record to JSON format. use if -parser when not "json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-format (json|none) (default none)
is better I think. For example, enable to add -format parquet
in feature.
…et in the future.
fujiwara
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🍿 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR
Currently, only jsonl S3 objects can be routed.
However, there was a usecase where I wanted to route CloudFront's Standard Log.
Furthermore, after routing, I would like to read the log using Redshift Spectrum or Athena.
Therefore, it is a little convenient if the S3 object after routing is in JSONL format.