Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic on run --dry-run #767

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix panic on run --dry-run #767

merged 2 commits into from
Nov 6, 2024

Conversation

fujiwara
Copy link
Contributor

@fujiwara fujiwara commented Nov 6, 2024

Fixes #764

Refactor task definition handling and related tests.

  • Introduced taskDefinitionForRun type to encapsulate task definition details. (run.go)
  • Replaced taskDefinitionArnForRun method with resolveTaskDefinitionForRun to return taskDefinitionForRun instances. (run.go)

@fujiwara fujiwara merged commit 7190398 into v2 Nov 6, 2024
4 checks passed
@fujiwara fujiwara deleted the fix/run-dry branch November 6, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail when ecspresso run --dry-run in v2.4.2
1 participant