Skip to content

Commit

Permalink
[BUG][TSVB] Fix serial diff agg link (opensearch-project#3503) (opens…
Browse files Browse the repository at this point in the history
…earch-project#3506)

Doc link was invalid and causing an undefined error. This
prevented the UI from mounting properly.

Issue(s) resolved:
* opensearch-project#3498
* opensearch-project#3327

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 69bcbfe)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
1 parent b4427df commit 1c042cd
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ export const SerialDiffAgg = (props) => {
const handleNumberChange = createNumberHandler(handleChange);

const htmlId = htmlIdGenerator();
const docLinks = useOpenSearchDashboards().services.docLinks;
const serialDiffDoc = useOpenSearchDashboards().services.docLinks?.links.opensearch.aggregations
.pipeline.serial_diff;

return (
<AggRow
Expand Down Expand Up @@ -111,7 +112,7 @@ export const SerialDiffAgg = (props) => {
id="visTypeTimeseries.serialDiff.lagLabel"
defaultMessage="Lag"
description={`'Lag' refers to the parameter name of the serial diff translation
${docLinks.services.links.opensearch.aggregations.pipeline.serial_diff}.
${serialDiffDoc}.
This should only be translated if there is a reasaonable word explaining what that parameter does.`}
/>
}
Expand Down

0 comments on commit 1c042cd

Please sign in to comment.