forked from aws-amplify/amplify-cli
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hosting language updates #2
Open
swaminator
wants to merge
4
commits into
kaustavghosh06:master
Choose a base branch
from
swaminator:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -105,7 +105,7 @@ export class StackHelper { | |||
spinner.start(`Deleting Amplify Console stack for ${envName} environment`); | |||
await cfnClient.deleteStack(params).promise().catch(err => { | |||
if (err.code === VALIDATION_ERROR) { | |||
spinner.succeed(`Deleting Amplify Console stack for ${envName} environment completed.`); | |||
spinner.succeed(`${envName} environment deletion complete.`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add "frontend" or "Amplify console" somewhere to differentiate this from the backend env.
kaustavghosh06
force-pushed
the
master
branch
from
October 15, 2019 23:46
ea5c7e9
to
7fb24f7
Compare
kaustavghosh06
pushed a commit
that referenced
this pull request
Dec 28, 2019
…aws-amplify#2905) * fix(amplify-codegen-appsync-model-plugin): use LazyCollection (JS/TS) Connected models to use LazyCollection in the generated Java Script and TypeScript code * address review commet * address review commet #2
kaustavghosh06
force-pushed
the
master
branch
2 times, most recently
from
November 22, 2020 04:27
0f14c89
to
0f4db2a
Compare
kaustavghosh06
force-pushed
the
master
branch
2 times, most recently
from
March 4, 2021 02:04
a1ce9db
to
53588c5
Compare
kaustavghosh06
pushed a commit
that referenced
this pull request
Jun 21, 2021
* feat: display SNS sandbox status * chore: SNS API error handling * chore: add support for SMS Sandbox check * chore: auth add show sandbox warning * chore: add some tests * chore: address review comments and remove unused code
kaustavghosh06
force-pushed
the
master
branch
from
November 15, 2021 00:05
df7db5b
to
c28c000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.