doc update #873
Merged
doc update #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katspaugh
reviewed
Nov 30, 2016
| @@ -102,7 +102,7 @@ grunt coverage | |||
| The HTML report can be found in `coverage/html/index.html`. | |||
|
|
|||
| ## Editing documentation | |||
| The homepage and the documentation are in the [`gh-pages` branch](https://github.com/katspaugh/wavesurfer.js/tree/gh-pages). Contributions to the documentation are especially welcome. | |||
| The homepage and documentation files are maintained in the [`gh-pages` branch](https://github.com/katspaugh/wavesurfer.js/tree/gh-pages). Contributions to the documentation are especially welcome. | |||
There was a problem hiding this comment.
Thanks! Out of curiosity, what was unclear with the previous wording?
There was a problem hiding this comment.
The original text was correct. The edited version is slightly clearer. I would only disagree with adding "are maintained." The existence of the files implies updates, edits and rewrites.
There was a problem hiding this comment.
I guess I meant are maintained elsewhere aka a different branch. Should I add that @katspaugh?
There was a problem hiding this comment.
I think your current version is fine.
katspaugh
approved these changes
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.