Wrap drawing in requestAnimationFrame (multicanvas).

[agamemnus]

Wrap drawing in requestAnimationFrame (multicanvas) per #1084.

Blocked by #1107.

[mspae]

Can you add support for opera and IE? … Maybe this would be something to put in utils, since it is also used in MultiCanvas and potentially other places.

[mspae]

Maybe something like this: https://gist.github.com/mrdoob/838785

[agamemnus]

K. I'll change it in a bit.

…

On May 27, 2017 4:48 AM, "Martin Spencer" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/drawer.multicanvas.js <#1106 (comment)> : > @@ -140,97 +140,105 @@ WaveSurfer.util.extend(WaveSurfer.Drawer.MultiCanvas, { }, drawBars: function (peaks, channelIndex, start, end) { - // Split channels - if (peaks[0] instanceof Array) { - var channels = peaks; - if (this.params.splitChannels) { - this.setHeight(channels.length * this.params.height * this.params.pixelRatio); - channels.forEach(function(channelPeaks, i) { - this.drawBars(channelPeaks, i, start, end); - }, this); - return; - } else { - peaks = channels[0]; + var requestAnimationFrame = window.requestAnimationFrame || window.webkitRequestAnimationFrame; Maybe something like this: https://gist.github.com/mrdoob/838785 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1106 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADFJWHS50QbwoW72Y9ktMTVPncUCsD2mks5r9-NJgaJpZM4NoQWj> .

[agamemnus]

I don't know what's going on here.

[katspaugh]

utils is undefined. It has to be WaveSurfer.util. Please also restore the spaces after the function keyword.

[agamemnus]

It's a function call though. Tough call..

[agamemnus]

Also I wrapped drawLine by accident instead of the one above it (or so). My bad.

[thijstriemstra]

anyone an idea what this error is about? https://travis-ci.org/katspaugh/wavesurfer.js/builds/237172952#L352

[agamemnus]

Yeah... it's because I don't have all the requestAnimationFrame PRs in one place, so it doesn't know about util.frame...

[thijstriemstra]

You'll probably have to bring in more code in this PR so the travis build doesn't fail, or find a way to make travis build happy.

[agamemnus]

Once the util PR is accepted, this one will work.

[thijstriemstra]

what pr number?

[agamemnus]

The one you pinged me about 20 min ago...! :P

#1107

[thijstriemstra]

cool, just for reference so others don't have to dig around for the PR nr. You should probably add to the PR description something like "blocked by PR #" (for every relevant PR you made/make).

[thijstriemstra]

Tests fail with:

TypeError: Illegal invocation

	    at Object.drawWave (dist/wavesurfer.min.js:4:9038)

	    at Object.t.Drawer.drawPeaks (dist/wavesurfer.min.js:4:21459)

	    at Object.t.empty (dist/wavesurfer.min.js:4:8462)

	    at Object.t.load (dist/wavesurfer.min.js:4:5975)

	    at Object.<anonymous> (spec/wavesurfer.spec.js:23:20)

so this type of method definition isn't allowed it seems..

[agamemnus]

It's completely unclear what is going on here. The same changes worked in the Canvas PR.

[katspaugh]

Weird. Can you reproduce this error locally?

[agamemnus]

Found the issue. See: #1120.

[katspaugh]

The tests pass now, thanks!