"for... in" should not be used with arrays. This causes bugs!

[agamemnus]

See: #1014.

I also changed "entry" to "canvas" since they are canvases. And, uh, just a few styling ideas.

[katspaugh]

Could you just replace the for-in with a forEach without the other stylistic changes? Btw, forEach takes a third argument which is the context of the callback, so you could pass this and not introduce another var my = this to keep the context.

[agamemnus]

I already ended up removing many of those changes due to your draconian style checker! The rest is as follows --

There are only four differences now, other than the forEach fixes, and corresponding "my" variables -- the "my" variables isn't something I came up with as it was present in an existing function.

1. Some brackets had an errant starting space: e.g.: { width: elementWidth + 'px'}. and the getImage function didn't have a space between it and the parameters.
2. entry -> canvas and lastEntry -> lastCanvas. IMO, if you have this.canvases, then one of them should be a canvas and not an entry.
3. Some breaking up of a multi-line var:

var elementWidth = Math.round(width / this.params.pixelRatio),
totalWidth = Math.round(this.width / this.params.pixelRatio);

to

var elementWidth = Math.round(width / this.params.pixelRatio);
var totalWidth   = Math.round(this.width / this.params.pixelRatio);

and

var entry = {},
leftOffset = this.maxCanvasElementWidth * this.canvases.length;

to

var canvas = {};
var leftOffset = this.maxCanvasElementWidth * this.canvases.length;

var endCanvas = Math.min(Math.ceil((x + width) / this.maxCanvasWidth) + 1,
this.canvases.length);

to

var endCanvas = Math.min(Math.ceil((x + width) / this.maxCanvasWidth) + 1, this.canvases.length);

Thanks for your work!

[katspaugh]

While some of your changes make sense (I'll mark them with a thumbs-up in the changeset), some are arbitrary, and I would rather not create more maintenance work for the next branch.

[katspaugh]

👍 except for the extra space after forEach – it's not needed.

[katspaugh]

👍

this.canvases.forEach(function (canvas) {
    this.clearWaveForEntry(canvas);
}, this);

[katspaugh]

The same comment as above.

[katspaugh]

👍

[agamemnus]

OK, give me a few minutes to make the appropriate changes.

[agamemnus]

Ok, I removed almost all of the other changes.

I also implemented your suggestion about inserting a this variable in forEach.

[katspaugh]

I still see a lot of other changes in the diff.

[agamemnus]

I fixed some errors.

The only other change now is removing space between opening/closing brackets and text. You don't really even have that consistent... those spaces are really terrible...

[agamemnus]

Ok, a few more I didn't notice.

[agamemnus]

I really hate those extraneous spaces, but I added them back. I also added some extra extraneous spaces in style definition calls for it to be consistent.

[katspaugh]

Could you revert this change, too?

[agamemnus]

Ok.

[katspaugh]

Merged, thanks!