Add support for forceDecode #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `forceDecode` option to force client side decoding of the audio after download regardless if pre-decoded peaks are passed to the `.load/2` method. This is primarily for use with `.zoom/1` to enable high fidelity rendering on zoom. Without local decoding, the zoom on pre-decoded peaks is very low fidelity.
katspaugh
approved these changes
Feb 25, 2017
|
Merged, thanks a lot! |
mspae
pushed a commit
to mspae/wavesurfer.js
that referenced
this pull request
Mar 5, 2017
* Add support for forceDecode Adds the `forceDecode` option to force client side decoding of the audio after download regardless if pre-decoded peaks are passed to the `.load/2` method. This is primarily for use with `.zoom/1` to enable high fidelity rendering on zoom. Without local decoding, the zoom on pre-decoded peaks is very low fidelity. * Update conditional brackets for failing test
mspae
added a commit
that referenced
this pull request
Mar 8, 2017
* added contributing info (#1006) * Readded global audio context singleton, functionally equal to PR #1021 * Cleanup npm package (#995) * ignore eclipse project files * exclude everything except dist, plugin and src directories in npm package * only include minified plugins in npm package * updated .npmignore to exclude everything except dist and src directories and subdirectories * Add support for forceDecode (#1009) * Add support for forceDecode Adds the `forceDecode` option to force client side decoding of the audio after download regardless if pre-decoded peaks are passed to the `.load/2` method. This is primarily for use with `.zoom/1` to enable high fidelity rendering on zoom. Without local decoding, the zoom on pre-decoded peaks is very low fidelity. * Update conditional brackets for failing test * nullify this.arraybuffer when destroying to prevent memory leak * removed <<<< HEAD * return array when using getImage() (#1027) * return array when using getImage() * return one canvas image data if not multiple canvases * Update drawer.multicanvas.js * updated getImage() * add comments fir getImage() * updated comments * updated getImage to es6 syntax and applied jsdoc formatting * create new labels feature for spectrogram plugin (#984) * create new labels feature for spectrogram plugin - create labels parameter (true|false) - create labels element and canvas - create labels frequency method loadLabels(); - update createWrapper() method and apply labels feature parameter. * create new labels feature for spectrogram plugin create new labels feature for spectrogram plugin - create labels parameter (true|false) - create labels element and canvas - create labels frequency method loadLabels(); - update createWrapper() method and apply labels feature parameter. * remove extra spaces * removed one more extra white space :) * update css formatting * remove extra space * remove extra space * Updated spectrogram labels to es6 * add getFilters method (#982) * add getFilters method * add getFilters() method add 'Filters must be set with setFilters method first' note. * return empty array if no filters are set * change to `return this.backend.filters || [];` * add debounce to resize/orientationchange event for minimap plugin (#987) * add debounce to resize event * add orientationchange event * getVolume method (#978) * getVolume method returns the current gainNode volume. * added getVolume method * added getVolume method * updated getVolume to es6 syntax * avoid error when calling pause before play (#977) This prevents a `Failed to execute 'stop' on 'AudioBufferSourceNode'` when stop() is called before play(). * fix getDuration() return value when using MediaElement (#941) * fix getDuration() return value for MediaElement change getDuration function in mediaelement.js to return the correct duration length same as WebAudio. from var duration = this.media.duration; // incorrect duration value returned console.log preview: https://cloud.githubusercontent.com/assets/5193884/22399178/6d26c1fe-e565-11e6-9b13-e6107641666a.png to var duration = this.buffer.duration; // correct duration value returned same as WebAudio console.log preview: https://cloud.githubusercontent.com/assets/5193884/22393549/7b130096-e4d6-11e6-83ff-4ebb78b9e42f.png * Update mediaelement.js * add wavesurfer.getPlaybackRate() (#939) add getPlaybackRate method and return playback rate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes:
Adds the
forceDecodeoption to force client side decoding of the audio after download regardless if pre-decoded peaks are passed to the.load/2method.This is primarily for use with
.zoom/1to enable high fidelity rendering on zoom of instant loading pre-decoded waveforms on the UI. Without local decoding, the zoom on pre-decoded peaks is very low fidelity.Included in this PR is alpha sorting of the
defaultParamsto make for easier reference. I couldn't resist...Breaking in the external API:
n/a
Breaking changes in the internal API:
n/a
Todos/Notes:
n/a
Related Issues and other PRs:
#999