Regions plugin: Only add resize handles if resize prop is true (#3171)

katspaugh · Sep 11, 2023 · e796e5a · e796e5a
1 parent 8bda65a
commit e796e5a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/cypress/e2e/regions.cy.js b/cypress/e2e/regions.cy.js
@@ -308,4 +308,23 @@ describe('WaveSurfer Regions plugin tests', () => {
       win.wavesurfer.destroy()
     })
   })
+
+  it('should not add resize handles if resize is set to false', () => {
+    cy.window().then((win) => {
+      const regionsPlugin = win.wavesurfer.getActivePlugins()[0]
+
+      const region = regionsPlugin.addRegion({
+        id: 'no-resize-region',
+        start: 1,
+        end: 5,
+        resize: false,
+      })
+
+      expect(region).to.be.an('object')
+      expect(region.element).to.be.an('HTMLDivElement')
+      expect(region.element.children).to.have.length(0)
+
+      win.wavesurfer.destroy()
+    })
+  })
 })
diff --git a/src/plugins/regions.ts b/src/plugins/regions.ts
@@ -115,7 +115,7 @@ class SingleRegion extends EventEmitter<RegionEvents> {
     )
 
     // Add resize handles
-    if (!isMarker) {
+    if (!isMarker && this.resize) {
       const leftHandle = document.createElement('div')
       leftHandle.setAttribute('data-resize', 'left')
       leftHandle.setAttribute(