Automated rollback of commit 3774f00.

*** Reason for rollback ***

Performance regression, b/294105788

*** Original change description ***

Implement REPO.bazel

- REPO.bazel is a new file at the root of repos that can only contain a `repo()` call with a bunch of package default arguments (similar to `package()`)
- A new SkyFunction, RepoFileFunction, evaluates a REPO.bazel file and returns the `PackageArgs` object containing those arguments
- PackageFunction for packages in repo `@foo` now depends on RepoFileFunction for `@foo`

Fixes bazelbuild#18077

PiperOrigin-RevId: 553500673
Change-Id: I866e73262ab75635c8927f8c77eb5412c01e16a9

src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkGlobalsImpl.java

@@ -22,7 +22,6 @@
 import com.google.devtools.build.lib.collect.nestedset.Depset;
 import com.google.devtools.build.lib.packages.BuildGlobals;
 import com.google.devtools.build.lib.packages.Proto;
-import com.google.devtools.build.lib.packages.RepoCallable;
 import com.google.devtools.build.lib.packages.SelectorList;
 import com.google.devtools.build.lib.packages.StarlarkGlobals;
 import com.google.devtools.build.lib.packages.StarlarkNativeModule;
@@ -121,11 +120,4 @@ public ImmutableMap<String, Object> getSclToplevels() {
     env.put("struct", StructProvider.STRUCT);
     return env.buildOrThrow();
   }
-
-  @Override
-  public ImmutableMap<String, Object> getRepoToplevels() {
-    ImmutableMap.Builder<String, Object> env = ImmutableMap.builder();
-    Starlark.addMethods(env, RepoCallable.INSTANCE);
-    return env.buildOrThrow();
-  }
 }

src/main/java/com/google/devtools/build/lib/cmdline/LabelConstants.java

@@ -44,7 +44,6 @@ public class LabelConstants {
   public static final PathFragment WORKSPACE_DOT_BAZEL_FILE_NAME =
       PathFragment.create("WORKSPACE.bazel");
   public static final PathFragment MODULE_DOT_BAZEL_FILE_NAME = PathFragment.create("MODULE.bazel");
-  public static final PathFragment REPO_FILE_NAME = PathFragment.create("REPO.bazel");
 
   public static final PathFragment MODULE_LOCKFILE_NAME = PathFragment.create("MODULE.bazel.lock");
 

src/main/java/com/google/devtools/build/lib/packages/PackageArgs.java

@@ -37,8 +37,6 @@
  */
 @AutoValue
 public abstract class PackageArgs {
-  public static final PackageArgs EMPTY = PackageArgs.builder().build();
-
   public static final PackageArgs DEFAULT =
       PackageArgs.builder()
           .setDefaultVisibility(RuleVisibility.PRIVATE)

src/main/java/com/google/devtools/build/lib/packages/StarlarkGlobals.java

@@ -64,7 +64,4 @@ public interface StarlarkGlobals {
 
   /** Returns the top-levels for .scl files. */
   ImmutableMap<String, Object> getSclToplevels();
-
-  /** Returns the top-levels for REPO.bazel files. */
-  ImmutableMap<String, Object> getRepoToplevels();
 }

src/main/java/com/google/devtools/build/lib/packages/StarlarkNativeModule.java

@@ -68,6 +68,7 @@
 import net.starlark.java.syntax.Location;
 
 /** The Starlark native module. */
+// TODO(cparsons): Move the definition of native.package() to this class.
 public class StarlarkNativeModule implements StarlarkNativeModuleApi {
   private static final GoogleLogger logger = GoogleLogger.forEnclosingClass();
 

src/main/java/com/google/devtools/build/lib/skyframe/BUILD

@@ -167,8 +167,6 @@ java_library(
         ":recursive_package_provider_backed_target_pattern_resolver",
         ":recursive_pkg_function",
         ":recursive_pkg_value",
-        ":repo_file_function",
-        ":repo_file_value",
         ":repository_mapping_function",
         ":repository_mapping_value",
         ":rule_configured_target_value",
@@ -2195,40 +2193,6 @@ java_library(
     ],
 )
 
-java_library(
-    name = "repo_file_function",
-    srcs = ["RepoFileFunction.java"],
-    deps = [
-        ":precomputed_value",
-        ":repo_file_value",
-        ":repository_mapping_value",
-        "//src/main/java/com/google/devtools/build/lib/actions:file_metadata",
-        "//src/main/java/com/google/devtools/build/lib/cmdline",
-        "//src/main/java/com/google/devtools/build/lib/events",
-        "//src/main/java/com/google/devtools/build/lib/packages",
-        "//src/main/java/com/google/devtools/build/lib/rules:repository/repository_directory_value",
-        "//src/main/java/com/google/devtools/build/lib/vfs",
-        "//src/main/java/com/google/devtools/build/lib/vfs:pathfragment",
-        "//src/main/java/com/google/devtools/build/skyframe",
-        "//src/main/java/com/google/devtools/build/skyframe:skyframe-objects",
-        "//src/main/java/net/starlark/java/eval",
-        "//src/main/java/net/starlark/java/syntax",
-        "//third_party:jsr305",
-    ],
-)
-
-java_library(
-    name = "repo_file_value",
-    srcs = ["RepoFileValue.java"],
-    deps = [
-        ":sky_functions",
-        "//src/main/java/com/google/devtools/build/lib/cmdline",
-        "//src/main/java/com/google/devtools/build/lib/packages",
-        "//src/main/java/com/google/devtools/build/skyframe:skyframe-objects",
-        "//third_party:auto_value",
-    ],
-)
-
 java_library(
     name = "repository_mapping_function",
     srcs = ["RepositoryMappingFunction.java"],

src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java

@@ -63,7 +63,6 @@
 import com.google.devtools.build.lib.server.FailureDetails.PackageLoading.Code;
 import com.google.devtools.build.lib.skyframe.BzlLoadFunction.BzlLoadFailedException;
 import com.google.devtools.build.lib.skyframe.GlobValue.InvalidGlobPatternException;
-import com.google.devtools.build.lib.skyframe.RepoFileFunction.BadRepoFileException;
 import com.google.devtools.build.lib.skyframe.StarlarkBuiltinsFunction.BuiltinsFailedException;
 import com.google.devtools.build.lib.util.DetailedExitCode;
 import com.google.devtools.build.lib.util.Pair;
@@ -1241,24 +1240,6 @@ private LoadedPackage loadPackage(
     IgnoredPackagePrefixesValue repositoryIgnoredPackagePrefixes =
         (IgnoredPackagePrefixesValue)
             env.getValue(IgnoredPackagePrefixesValue.key(packageId.getRepository()));
-    RepoFileValue repoFileValue;
-    try {
-      repoFileValue =
-          (RepoFileValue)
-              env.getValueOrThrow(
-                  RepoFileValue.key(packageId.getRepository()),
-                  IOException.class,
-                  BadRepoFileException.class);
-    } catch (IOException | BadRepoFileException e) {
-      throw PackageFunctionException.builder()
-          .setType(PackageFunctionException.Type.BUILD_FILE_CONTAINS_ERRORS)
-          .setPackageIdentifier(packageId)
-          .setTransience(Transience.PERSISTENT)
-          .setException(e)
-          .setMessage("bad REPO.bazel file")
-          .setPackageLoadingCode(PackageLoading.Code.BAD_REPO_FILE)
-          .build();
-    }
     if (env.valuesMissing()) {
       return null;
     }
@@ -1394,9 +1375,8 @@ private LoadedPackage loadPackage(
               .setFilename(buildFileRootedPath)
               .setConfigSettingVisibilityPolicy(configSettingVisibilityPolicy);
 
-      pkgBuilder
-          .mergePackageArgsFrom(PackageArgs.builder().setDefaultVisibility(defaultVisibility))
-          .mergePackageArgsFrom(repoFileValue.packageArgs());
+      pkgBuilder.mergePackageArgsFrom(
+          PackageArgs.builder().setDefaultVisibility(defaultVisibility));
 
       Set<SkyKey> globDepKeys = ImmutableSet.of();