Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-readonly block op buffers in mem #9

Merged
merged 1 commit into from
Feb 25, 2020
Merged

non-readonly block op buffers in mem #9

merged 1 commit into from
Feb 25, 2020

Conversation

magodo
Copy link
Contributor

@magodo magodo commented Feb 12, 2020

Fix a TODO that in case of write back, do not write to temp file but store in bytes.Buffer and later copy from there to dest file.

katbyte
katbyte approved these changes Feb 25, 2020
View reviewed changes
Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this too @magodo! LGTM 👍

@katbyte katbyte merged commit 8f95a35 into katbyte:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magodo @katbyte