Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow uppercase letters to resource name on block reader #56

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

jeremmfr
Copy link
Contributor

Uppercase letters in the resource name are allowed but the block reader doesn't detect the block in this case

@jeremmfr jeremmfr changed the title allow capital letters to resource name on block reader allow uppercase letters to resource name on block reader Apr 30, 2022
Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeremmfr - LGTM 🚜

@katbyte katbyte added this to the v0.5.0 milestone Aug 3, 2022
@katbyte katbyte merged commit c39e71c into katbyte:main Aug 3, 2022
katbyte added a commit that referenced this pull request Aug 3, 2022
@jeremmfr
Copy link
Contributor Author

@katbyte This MR has been revert by #67, recreated in #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants