Add JSON output for blocks command
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdavison
commented
Aug 6, 2020
| return encoder.Encode(w.data) | ||
| } | ||
|
|
||
| func findBlocksInFile(fs afero.Fs, log *logrus.Logger, filename string, verbose, zeroTerminated, jsonOutput bool, stdin io.Reader, stdout, stderr io.Writer) error { |
There was a problem hiding this comment.
This is starting to feel a bit unwieldy, with all the flags being passed as parameters. At some point, a command object containing the configuration should probably be created.
There was a problem hiding this comment.
agreed, but that is for another pr!
katbyte
approved these changes
Aug 13, 2020
| return encoder.Encode(w.data) | ||
| } | ||
|
|
||
| func findBlocksInFile(fs afero.Fs, log *logrus.Logger, filename string, verbose, zeroTerminated, jsonOutput bool, stdin io.Reader, stdout, stderr io.Writer) error { |
There was a problem hiding this comment.
agreed, but that is for another pr!
# Conflicts: # README.md # cli/blocks_test.go # cli/cmds.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option for JSON blocks output to feed into other tools using, e.g.
jq. Uses the flags--jsonor-j.Output format is
{ "block_count": 1, "blocks": [ { "start_line": 4, "end_line": 9, "text": "..." } ] }Depends on #25 and #22