-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
0fbb956
to
9841d31
Compare
Lgtm. |
Changes lgtm. The CI is noting your PR does not meet all of our formatting requirements - and gives you a hint and link :-) ...
|
@grahamwhaley I guess this can group under "build" ? |
@sudeeshjohn yep, that would be fine. |
9841d31
to
5cad541
Compare
updated commit message. |
.ci/setup.sh
Outdated
@@ -67,6 +67,9 @@ enable_nested_virtualization() { | |||
aarch64) | |||
info "CI running in bare machine" | |||
;; | |||
ppc64le) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a hint, to avoid repeating the same info
message you could do:
aarch64 | ppc64le)
info "CI running in bare machine"
;;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcov thanks for the hint .. updated the patch accordingly
Once we have this merge, it would be useful to have a bare metal server set up that could run tests for PPC, similarly with what we are doing for ARM (reference: kata-containers/ci#30) |
..and thanks @sudeeshjohn for your contribution. |
@marcov: Yes, we are in the process of getting a bare metal Power server with a public IP for our CI. Are there any other specific requirements for a server that we may miss for CI? (going through the link you provided as well). |
5cad541
to
3c055d2
Compare
including ppc64le arch too into the ci scripts Fixes: kata-containers#883 Signed-off-by: Sudeesh John [email protected]
3c055d2
to
d560e58
Compare
That's cool! I can't see any specific requirements, but @chavafg, @grahamwhaley and @jodh-intel may have a better insight about it. |
Running tests just to get green checks, even if this PR shoudn't have broken anything |
There are no really hard/strict requirements that I'm aware of. You need the 'slave' set up enough to be a Jenkins slave, and be able to launch our jenkins script. We should maybe clarify if this is a single slave machine that will be tied into our kata jenkins master, of if this is maybe a single or pair of machines that will run a complete separate Jenkins instance just for ppc64. We currently run the x86 QA CI on oneshot cloud instances. That gives us a nice degree of isolation from a test run corrupting somehow a machine (it does happen). I wrote up some notes over here a while back. I also wrote up and coded a way to use oneshot VMs on the machines to alleviate this here. Although I put that together for running the metrics CI, I believe that would work for QA CI as well. I am also about to post some ansible scripts that can deploy a machine with enough bits to run either a jenkins slave directly, or setup the nested VMs. Not quite there yet - but if you could do with them, nudge me, and I could push a prelim branch you can stare at. |
lgtm Hi @nitkon, in addition to the good summary of @grahamwhaley, our current VMs are launched with 4 vCPUs and 16 GB of memory. I remember that CPU tests failed when the machine had less than 4 CPUs, so it would be good to at least match that number. I the case of the memory, I think 8GB has also worked in the past. Please let me know when you have the resource, I can help you set up as a slave. |
Fixes: #883
Signed-off-by: Sudeesh John [email protected]