This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
ci: Add virtio-fs support #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add the command to enable on the system too? |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
5d6a1ba
to
d62837a
Compare
|
@ganeshmaharaj addressed your comment |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
d62837a
to
04a0319
Compare
|
/test-nemu |
Seems like we have memory issues when running with virtiofs, maybe because of hugepages? |
|
@ganeshmaharaj is already aware that hugepages are actually not needed, which is why he has a patch in flight I think. If the issue comes from hugepages, this will be solved by not using them because they're not needed per se. |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
04a0319
to
d83ba86
Compare
|
/test-nemu |
|
@chavafg hi, any update? |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
d83ba86
to
ac7ab85
Compare
|
/test-nemu |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
ac7ab85
to
203d0f8
Compare
ganeshmaharaj
approved these changes
May 15, 2019
|
/test |
|
Restarted Nemu test which failed with: Restarted the initrd CI failed with this rather weird set of messages: |
jodh-intel
approved these changes
May 16, 2019
|
seems like docker memory tests with nemu (which use virtiofs in this PR) are getting hanged. need to check furtherly |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
203d0f8
to
ee458d2
Compare
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
ee458d2
to
7e15010
Compare
|
/test-nemu |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
7e15010
to
acad792
Compare
ganeshmaharaj
suggested changes
May 28, 2019
.ci/install_runtime.sh
Outdated
| # currently we use nemu for virtiofs testing | ||
| if [ "$VIRTIO_FS" = true ] && [ "$KATA_HYPERVISOR" = "nemu" ]; then | ||
| echo "Configure virtio-fs on kata-runtime config file" | ||
| sudo crudini --set "$runtime_config_path" hypervisor.qemu virtio_fs_daemon "\"/usr/local/bin/virtiofsd-${arch}\"" |
There was a problem hiding this comment.
After #1595, maybe we can remove the hardcoding of the virtiofsd binary and use ${KATA_NEMU_DESTDIR}
.ci/install_runtime.sh
Outdated
| echo "Configure virtio-fs on kata-runtime config file" | ||
| sudo crudini --set "$runtime_config_path" hypervisor.qemu virtio_fs_daemon "\"/usr/local/bin/virtiofsd-${arch}\"" | ||
| sudo crudini --set "$runtime_config_path" hypervisor.qemu shared_fs "\"virtio-fs\"" | ||
| sudo crudini --set "$runtime_config_path" hypervisor.qemu enable_hugepages "true" |
There was a problem hiding this comment.
We should not longer need this. File based backend patch landed today and that should automatically take care of this part.
chavafg
force-pushed
the
topic/virtiofs-support
branch
2 times, most recently
from
7bb389a
to
203786d
Compare
|
/test-nemu |
ganeshmaharaj
approved these changes
May 29, 2019
|
@ganeshmaharaj now the tests are getting hanged on the cri-o tests when trying to create a container inside a pod. I just see timeout error on the kata logs, but the lasts messages are from I tried to reproduce locally, these are the logs: any idea? |
|
@chavafg can we just use the nemu hypervisor with its default toml now? Is this PR still needed? |
|
I need to change the PR to now use the |
I seem to have missed it. is this still an issue? I just tested and it seems to be working fine. and we have fixed the hotplug issue. Once the patch lands in runtime, we can turn that test back on as well. |
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
203786d
to
8e860f6
Compare
|
/test-nemu |
The kata-containers configuration file for nemu already uses virtiofs as default. Use this config file to run the CI with nemu and virtiofs. In addition, this change also skips memory related tests as kata-containers/runtime#1745 is still open. Fixes: kata-containers#1536. Signed-off-by: Salvador Fuentes <[email protected]>
we still have some issues running memory hotplug using virtiofs, so many of the cri-o and k8s tests do not run as expected. This should be resolved on kata-containers/runtime#1810, but in the meantime run only docker related tests. Signed-off-by: Salvador Fuentes <[email protected]>
chavafg
force-pushed
the
topic/virtiofs-support
branch
from
bb57290
to
ae8f8f1
Compare
|
/test |
|
Greeeeeeeeeen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration option to use virtio-fs.
We will currently use nemu for testing the
virtio-fs support.
Depends-on: github.com/kata-containers/runtime#1639
Fixes: #1536.
Signed-off-by: Salvador Fuentes [email protected]