This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
integration/docker: improve memory test #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consume twice the memory hot added to the container to guarantee the `out of memory` error. fixes kata-containers#1504 Signed-off-by: Julio Montes <[email protected]>
|
/test |
grahamwhaley
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
lgtm
I was peeking at this code earlier today, and noticed the hard wired '260'. I think StressImage could probably even take some sort of iterator - so we might be able to say to it 'allocate the size of the container memory *10, in containerMemory sized steps', and be really sure it will blow the memory budget :-)
chavafg
approved these changes
Apr 26, 2019
GabyCT
approved these changes
Apr 26, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume twice the memory hot added to the container to guarantee
the
out of memoryerror.fixes #1504
Signed-off-by: Julio Montes [email protected]