This repository has been archived by the owner on May 12, 2021. It is now read-only.
Add support for ipvlan network driver #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be merged after the PR for tc-filter. |
|
Is this related to #827? It would help if you could add a full PR reference if that's the case to make it easier to track what is going on :) |
|
cc @mcastelino |
mcastelino
reviewed
Oct 25, 2018
virtcontainers/ipvlan_endpoint.go
Outdated
| "github.com/containernetworking/plugins/pkg/ns" | ||
| ) | ||
|
|
||
| // IPVlanEndpoint represents a macvlan endpoint that is bridged to the VM |
There was a problem hiding this comment.
@amshinde copy paste error here
IPVlanEndpoint represents a macvlan endpoint
mcastelino
reviewed
Oct 25, 2018
| return &IPVlanEndpoint{}, fmt.Errorf("invalid network endpoint index: %d", idx) | ||
| } | ||
|
|
||
| // Use tc filtering for ipvlan, since the other inter networking models will |
There was a problem hiding this comment.
@amshinde are there any other cases you know of where macvlan or bridge does not work. Ideally you need to have a check that sees if the current interworkingModel works for this type of interface. This function can return what interworkingModel will support it, if the user selected one does not. This will make the code generic.
There was a problem hiding this comment.
@mcastelino Yes, I need to handle this for macvlan as well. I agree this code needs to be generic.
I think it will make sense to have an interface for each endpoint that advertises the internetworking models it supports. I will add that for every endpoint so that we can make a decision to fallback to a model that works for an endpoint.
I'll do this in a separate PR.
mcastelino
approved these changes
Oct 25, 2018
amshinde
force-pushed
the
ipvlan
branch
2 times, most recently
from
ffbb5ef
to
2dad048
Compare
|
@jodh-intel I shall add a reference going forward :) |
|
/retest |
Support ipvlan interfaces by setting up tc redirect rules. Fixes kata-containers#591 Signed-off-by: Archana Shinde <[email protected]>
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=========================================
Coverage ? 66.87%
=========================================
Files ? 87
Lines ? 11766
Branches ? 0
=========================================
Hits ? 7868
Misses ? 3082
Partials ? 816 |
sboeuf
approved these changes
Oct 26, 2018
|
LGTM! |
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Oct 31, 2018
Now that kata-containers/runtime#852 has been merged, we need to test docker integration tests with ipvlan driver with l2 and l3 mode. Fixes kata-containers#861 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Oct 31, 2018
Now that kata-containers/runtime#852 has been merged, we need to test docker integration tests with ipvlan driver with l2 and l3 mode. Fixes kata-containers#861 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Oct 31, 2018
Now that kata-containers/runtime#852 has been merged, we need to test docker integration tests with ipvlan driver with l2 and l3 mode. Fixes kata-containers#861 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 1, 2018
Now that kata-containers/runtime#852 has been merged, we need to test docker integration tests with ipvlan driver with l2 and l3 mode. Fixes kata-containers#861 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 9, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 12, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 12, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 13, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 13, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
GabyCT
added a commit
to GabyCT/tests-1
that referenced
this pull request
Nov 13, 2018
Now that macvlan and ipvlan has been merged kata-containers/runtime#852 and kata-containers/runtime#506, we can enable the test to run in our CI. Fixes kata-containers#899 Signed-off-by: Gabriela Cervantes <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ipvlan is supported using tc filtering rules to redirect traffic between the ipvlan interface and tap interface.